[GitHub] [tvm] PhilippvK commented on a diff in pull request #12534: [Docker][CI][RISC-V] Build riscv-isa-sim (spike) in ci_riscv Docker image to enable RISC-V unit testing

Mon, 22 Aug 2022 19:14:57 -0700 


PhilippvK commented on code in PR #12534:
URL: https://github.com/apache/tvm/pull/12534#discussion_r952081941


##########
python/tvm/micro/testing/aot_test_utils.py:
##########
@@ -65,6 +65,17 @@
     },
 )
 
+AOT_SPIKE_RUNNER = AOTTestRunner(

Review Comment:
   AFAIK AOTTestRunner and the MicroTVM Project API are just two different 
approaches. The latter is more powerful (allows autotuning, profiling) but 
comes with some overheads (due to RPC communication) while the test runner is 
very minimalistic but good enough for effective unit testing.
   
   I went the AOTTestRunner approach to run the existing AOT/CRT related test 
cases in a straightforward fashion. I am not sure if this was one of you goals? 
Feel free to propose which test should be run using spike instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to