janetsc commented on code in PR #13111:
URL: https://github.com/apache/tvm/pull/13111#discussion_r998526621
##########
tests/cpp-runtime/hexagon/hexagon_thread_manager_tests.cc:
##########
@@ -161,7 +162,8 @@ TEST_F(HexagonThreadManagerTest, pipe_fill) {
CHECK_EQ(answer, 42);
}
-TEST_F(HexagonThreadManagerTest, pipe_overflow) {
+// TODO(HWE): Create a temporary thread manager with a smaller pipe for this
test
Review Comment:
Per discussion this morning, one way around this is to split out a base
class for thread management, and then a HexagonThreadManager that inherits
this. Hardware acquisition only occurs from the HexagonThreadManager. We
could use that base class to test pipe length, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
