adstraw commented on code in PR #13111:
URL: https://github.com/apache/tvm/pull/13111#discussion_r998712225
##########
tests/cpp-runtime/hexagon/hexagon_thread_manager_tests.cc:
##########
@@ -161,7 +162,8 @@ TEST_F(HexagonThreadManagerTest, pipe_fill) {
CHECK_EQ(answer, 42);
}
-TEST_F(HexagonThreadManagerTest, pipe_overflow) {
+// TODO(HWE): Create a temporary thread manager with a smaller pipe for this
test
Review Comment:
Yes, would like to know the feasibility of splitting into testable base
class + HexagonThreadManager before we decide whether to land this PR with this
disabled test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
