janetsc commented on code in PR #13111:
URL: https://github.com/apache/tvm/pull/13111#discussion_r998715586
##########
tests/cpp-runtime/hexagon/hexagon_thread_manager_tests.cc:
##########
@@ -161,7 +162,8 @@ TEST_F(HexagonThreadManagerTest, pipe_fill) {
CHECK_EQ(answer, 42);
}
-TEST_F(HexagonThreadManagerTest, pipe_overflow) {
+// TODO(HWE): Create a temporary thread manager with a smaller pipe for this
test
Review Comment:
I think this might have some complexity when we parameterize the thread_main
for each hardware resource that will be dedicated to that thread. So I'd like
to postpone this until that task to acquire one hardware resource per thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
