masahi commented on code in PR #13642:
URL: https://github.com/apache/tvm/pull/13642#discussion_r1059588708
##########
python/tvm/topi/x86/dense.py:
##########
@@ -293,16 +324,13 @@ def dense_vnni_compute(cfg, X, packed_w, bias=None):
),
axis=ak,
),
- tag="dense_vnni",
- attrs={"schedule_rule": "dense_vnni"},
Review Comment:
This shouldn't be removed, it is used here
https://github.com/apache/tvm/blob/b16a64d6edb9fd1a014fc51995dff7d0e2f4c84e/tests/python/unittest/test_meta_schedule_vnni_integration.py#L198.
Since this only affects MetaSchedule, you don't have to provide this value
for AMX. So only when `dense_int8_compute` is called for VNNI, you need to
provide this attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
