masahi commented on code in PR #13642:
URL: https://github.com/apache/tvm/pull/13642#discussion_r1059735746
##########
python/tvm/topi/x86/dense.py:
##########
@@ -293,16 +324,13 @@ def dense_vnni_compute(cfg, X, packed_w, bias=None):
),
axis=ak,
),
- tag="dense_vnni",
- attrs={"schedule_rule": "dense_vnni"},
Review Comment:
Of course the test still works, because it was already written for VNNI. The
point is that the name `dense_vnni` tells that the particular TE expression is
meant for VNNI tensorization, in particular the weight is pre-packed
appropriately. But a generic name like `dense_int8` doesn't provide such
information.
So please revert that commit and restore and pass `attrs={"schedule_rule":
"meta_schedule.x86.dense_vnni"}` when you create a compute expression for VNNI.
`schedule_rule` is not relevant for AMX for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
