Qianshui-Jiang commented on code in PR #13642:
URL: https://github.com/apache/tvm/pull/13642#discussion_r1059723468
##########
python/tvm/topi/x86/dense.py:
##########
@@ -293,16 +324,13 @@ def dense_vnni_compute(cfg, X, packed_w, bias=None):
),
axis=ak,
),
- tag="dense_vnni",
- attrs={"schedule_rule": "dense_vnni"},
Review Comment:
> This shouldn't be removed, it is used here
>
>
https://github.com/apache/tvm/blob/b16a64d6edb9fd1a014fc51995dff7d0e2f4c84e/tests/python/unittest/test_meta_schedule_vnni_integration.py#L198
>
> .
> Since this only affects MetaSchedule, you don't have to provide this value
for AMX. So only when `dense_int8_compute` is called for VNNI, you need to
provide this attribute.
@masahi Sorry, may given the misunderstanding, I mean that can we use the
`dense_int8` in this test case? cuz here inject the VNNI intrinsic explicitly.
And by default in relay build flow, it will check if the VNNI or AMX is
availiable and chose different schedulling.
I've verified that this test case still functional after the little
modification [in this
commit](https://github.com/apache/tvm/pull/13642/commits/5718a059c69972cf71ea082a3303b5c29fa2d21f)
bellow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
