tqchen commented on PR #13707: URL: https://github.com/apache/tvm/pull/13707#issuecomment-1424236775
Just to summarize my comment here. It would be great to name the interface and file so to avoid confusion, For example use the term `interface_embedded_rust` would leave room and allow developers to not have confusion given there can be other interfaces of rust, as per discussion of rationales in this RFC https://github.com/apache/tvm-rfcs/pull/96 - G0: Avoid confusion with the normal rust API usage given there are multiple possibilities under a different API. To help move some of the decisions forward, here are possible ways that might help: - We can try to open a thread in the community to get a broad sense of what everyone's inputs are (wrt to the overall naming and scoping), which i would also be interested in hearing from. - If we feel a sequence of changes is needed that goes beyond a single PR to bring the set of things into a ready state, we can also try to open a branch, in which case the change is also reasonably isolate, and we are more than welcome to commit the change to branch, continue followup developments, and we can re-access when we think things are at a ready state to address G0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
