tqchen commented on PR #13707: URL: https://github.com/apache/tvm/pull/13707#issuecomment-1424939888
Might indeed is true that G0 is non-issue for the intended audience of this PR. Again G0 is not only about intended audiences of the PR, but also the general TVM project and non-embedded uses(and differentiate them from the embedded interface), and how to make our overall namespacing structure clear so we can empower both cases. G0 exist because rust is a general purpose language. If there is a suggestion to clarifying the scope of embedded API in the project for both C and rust, that could indeed be a better outcome, W2 likely offer a way to do so. Personally I also think the name of embedded c interface could be further clarified along the same line, but we can take one step at a time and given all the background mentioned, I do not take that ask as a blocker. But if there is a feeling that such sync should be done, either first make the c change in main then move on to the new style, or doing them in arbitrary order in W2 are both feasible. Taking W0 then updating embedded C would also achieve that goal as well. When W2 path is taken, there is of course not blocked on whether we have to take W0, as long as G0 is achieved. For example, moving both C and rust generator under a different namespace would be a reasonable choice that is not consistent with W0 but still achieve the goal. Usually it is indeed OK to defer some decisions of a module, provided that they are reasonabley isolated and clarified wrt to the overall scope of the project. Such requirements usually can be easily satiesfied with proper namespacing and isolation, to allow developer to own that part of submodule/subfolder, as long as their relation is satisified. Again considering the small impact of W0 to the intended users of the PR, and the clarity it offers to the wider community. I do not see it as a necessary bad. But there are also other paths available like I outlined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
