MasterJH5574 commented on code in PR #14183: URL: https://github.com/apache/tvm/pull/14183#discussion_r1125354651
########## include/tvm/relax/transform.h: ########## @@ -89,6 +89,13 @@ TVM_DLL Pass ToNonDataflow(); */ TVM_DLL Pass CallTIRRewrite(); +/*! + * \brief Perform explicit tensor allocation for call_dps_packed. + * + * \return The Pass. + */ +TVM_DLL Pass CallDPSPackedRewrite(); Review Comment: I’m wondering if we need this pass. I suppose that the lowering of `call_tir` and `call_dps_packed` are the same (the diff check also suggests this). The reason we want to introduce two is to reduce confusion. In terms of their lowering, I suppose they can directly share a same logic, which makes things easy (say when someone wants to change CallTIRRewrite, it won’t need to change CallDPSPackedRewrite in the same way as well). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
