slyubomirsky commented on code in PR #14183: URL: https://github.com/apache/tvm/pull/14183#discussion_r1128634605
########## include/tvm/relax/transform.h: ########## @@ -89,6 +89,13 @@ TVM_DLL Pass ToNonDataflow(); */ TVM_DLL Pass CallTIRRewrite(); +/*! + * \brief Perform explicit tensor allocation for call_dps_packed. + * + * \return The Pass. + */ +TVM_DLL Pass CallDPSPackedRewrite(); Review Comment: It might be fine to make them syntactic sugar for the same underlying operator. There are only two differences I can think of: 1. `call_tir` is generally assumed to be pure, whereas `call_dps_packed` may not be (unless we want to require it) 2. `call_tir` expects a `PrimFunc` as its operand, whereas `call_dps_packed` expects a `PackedFunc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
