yongwww commented on code in PR #14183: URL: https://github.com/apache/tvm/pull/14183#discussion_r1128704973
########## include/tvm/relax/transform.h: ########## @@ -89,6 +89,13 @@ TVM_DLL Pass ToNonDataflow(); */ TVM_DLL Pass CallTIRRewrite(); +/*! + * \brief Perform explicit tensor allocation for call_dps_packed. + * + * \return The Pass. + */ +TVM_DLL Pass CallDPSPackedRewrite(); Review Comment: Thanks for the comments! Actually I was struggling to add CallDPSPackedRewrite, it does duplicate lots of code from CallTIRRewrite, and modifying CallTIRRewrite to work for both call_tir and call_dps_packed brings some confusion (probably a different pass name). I removed CallDPSPackedRewrite in the latest commit, we can add it back when the differences are introduces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
