yongwww commented on code in PR #14388:
URL: https://github.com/apache/tvm/pull/14388#discussion_r1146969196


##########
include/tvm/relax/attrs/nn.h:
##########
@@ -29,6 +29,49 @@
 namespace tvm {
 namespace relax {
 
+/*! \brief Attributes used in Conv1d operator */
+struct Conv1DAttrs : public tvm::AttrsNode<Conv1DAttrs> {

Review Comment:
   looks it is quite similar to Conv2Dattrs, probably we can unify them into a 
ConvAttrs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to