LeshengJin commented on code in PR #14388:
URL: https://github.com/apache/tvm/pull/14388#discussion_r1147233571
##########
include/tvm/relax/attrs/nn.h:
##########
@@ -29,6 +29,49 @@
namespace tvm {
namespace relax {
+/*! \brief Attributes used in Conv1d operator */
+struct Conv1DAttrs : public tvm::AttrsNode<Conv1DAttrs> {
Review Comment:
Thank you for your review!
I am not sure if we need to unify them into a `ConvNDAttrs`, since there are
several differences between `Conv1d` and `Conv2d` that are worth noting.
1. `strides`/`dilation` for `Conv1d` can either be an integer or a
tuple/list of a single integer, whereas for `Conv2d`, it can be a list of two
integers, strides for H and W.
2. `padding` for `Conv1d` is at most a two-int list(padding left and right),
while for `Conv2d`, it can be a list of four integers that indicate padding on
the top, left, bottom, and right.
3. `data_layout`: "NCW" for `Conv1d` and "NCHW" for `Conv2d`.
4. `kernel_layout`: "OIW" for `Conv1d` and "OIHW" for `Conv2d`.
Let's get more feedbacks from the community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
