MasterJH5574 commented on code in PR #14388:
URL: https://github.com/apache/tvm/pull/14388#discussion_r1147933911
##########
include/tvm/relax/attrs/nn.h:
##########
@@ -29,6 +29,49 @@
namespace tvm {
namespace relax {
+/*! \brief Attributes used in Conv1d operator */
+struct Conv1DAttrs : public tvm::AttrsNode<Conv1DAttrs> {
Review Comment:
It seems possible to unify them together. We can do sanity checks in
respective struct info inference of conv1d and conv2d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
