slyubomirsky commented on code in PR #14394: URL: https://github.com/apache/tvm/pull/14394#discussion_r1192635253
########## include/tvm/relax/expr.h: ########## @@ -985,6 +985,11 @@ constexpr const char* kComposite = "Composite"; constexpr const char* kPartitionedFromPattern = "PartitionedFromPattern"; /*! \brief The required workspace for an external function. */ constexpr const char* kWorkspaceSize = "WorkspaceSize"; +/*! \brief Indicate whether the function is pure (has no visible side effects for any input). */ +constexpr const char* kIsPure = "IsPure"; Review Comment: I agree, actually. I brought up the issue before and at that time we didn't want to change the constructor. Maybe it's a better idea to do it in this PR to avoid even more disruption later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
