slyubomirsky commented on code in PR #14394: URL: https://github.com/apache/tvm/pull/14394#discussion_r1169034754
########## src/relax/analysis/well_formed.cc: ########## @@ -56,6 +56,14 @@ * * The op or args fields of Call nodes * * Inside the fields of Tuple nodes * 13. Expr always has checked_type_ (with the exception of Op). + * 14. DataflowBlocks may not contain If nodes. + * 15. DataflowBlocks may not contain calls to impure functions or operators + * (only checked if check_struct_info is true). + * 16. If a function is annotated as pure (kIsPure is true) + * and purity is not forced (kForcePure is true), + * the body may not contain any impure call + * (only checked if check_struct_info is true). + * 17. If a function's purity is forced, kForcePure cannot be true Review Comment: Sorry, that was a typo. `kIsPure` cannot be false in that case. Will fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
