slyubomirsky commented on code in PR #14394:
URL: https://github.com/apache/tvm/pull/14394#discussion_r1169031107
##########
src/relax/op/op.cc:
##########
@@ -464,7 +554,9 @@
TVM_REGISTER_GLOBAL("relax.op.memory.kill_storage").set_body_typed(MakeMemKillSt
RELAY_REGISTER_OP("relax.memory.kill_tensor")
.set_num_inputs(1)
.add_argument("tensor", "Expr", "The tensor to be killed.")
- .set_attr<FInferStructInfo>("FInferStructInfo", ReturnVoidStructInfo);
+ .set_attr<FInferStructInfo>("FInferStructInfo", ReturnVoidStructInfo)
+ // memory deallocation also isn't considered a "visible effect" as far as
purity is concerned
Review Comment:
Ooh, that's a mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
