YorkShen commented on a change in pull request #2783: [Android]support "wx" in
animation and wxtext
URL: https://github.com/apache/incubator-weex/pull/2783#discussion_r318943950
##########
File path: android/sdk/src/main/java/com/taobao/weex/utils/WXViewUtils.java
##########
@@ -280,6 +281,42 @@ public static float getRealPxByWidth(float pxValue,int
customViewport) {
return realPx > 0.005 && realPx < 1 ? 1 : (float) Math.rint(realPx);
}
}
+ public static float getRealPxByWidth(Object value, float df, int
customViewport) {
Review comment:
Please mark the following method as `@Deprecated` and `Use {@link
#getRealPxByWidth(Object, float, int)}` instead.
* `getRealPxByWidth(float pxValue)`
* `getRealPxByWidth(float pxValue,int customViewport)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
