YorkShen commented on a change in pull request #2783: [Android]support "wx" in
animation and wxtext
URL: https://github.com/apache/incubator-weex/pull/2783#discussion_r318943294
##########
File path: android/sdk/src/main/java/com/taobao/weex/utils/WXUtils.java
##########
@@ -135,7 +135,7 @@ public static Float getFloat(Object value, @Nullable Float
df) {
return df;
}
- private static float transferWx(String stringWithWXPostfix, int viewport) {
+ public static float transferWx(String stringWithWXPostfix, int viewport) {
Review comment:
Please mark the following method as `@Deprecated` and `Use {@link
WXViewUtils#getRealPxByWidth(Object, float, int)}` instead.
* `getFloat(Object value, @Nullable Float df)`
* `getFloatByViewport(Object value, int viewport) `
* `getFloat(Object value)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
