YorkShen commented on a change in pull request #2783: [Android]support "wx" in
animation and wxtext
URL: https://github.com/apache/incubator-weex/pull/2783#discussion_r319051896
##########
File path:
android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java
##########
@@ -204,11 +204,11 @@ ObjectAnimator createAnimator(final View target, final
int viewPortWidth) {
ViewGroup.LayoutParams layoutParams = target.getLayoutParams();
if (!TextUtils.isEmpty(style.width)) {
holders.add(PropertyValuesHolder.ofInt(new WidthProperty(),
layoutParams.width,
- (int)
WXViewUtils.getRealPxByWidth(WXUtils.getFloat(style.width), viewPortWidth)));
+ (int) WXViewUtils.getRealPxByWidth(style.width,0.0f,
viewPortWidth)));
Review comment:
The default/fallback value is `Float.NAN`, not zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
