[
https://issues.apache.org/jira/browse/WICKET-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068825#comment-13068825
]
Igor Vaynberg commented on WICKET-3899:
---------------------------------------
hrm. we need to write up a bunch of tests for IFormVisitorParticipant. a lot of
things seem to be rather broken.
looking at ValidationVisitor, for example, there is a check there and a call to
not go deeper if processChildren() returns false. however, this makes little
sense since the visitor is used at a postorder traversal and so by the time the
children are visited before the component - which makes dontgodeeper() a noop.
further, there is a problem with formvalidators. currently form validators only
check if the dependent form components are visible in hierarchy. but, they also
need to check if any parent of the component is a participant, and if they are
test if children should be processed. this should be done for the
rootform->component hierarchy in that order.
lots of work for this one... :/
> IFormVisitorParticipant don't get tested when validation method is visiting
> inner forms
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-3899
> URL: https://issues.apache.org/jira/browse/WICKET-3899
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.4.17, 1.5-RC5.1
> Reporter: Pedro Santos
> Attachments: WICKET-3899.patch
>
>
> The inconsistencies is at Form#validate method. It invokes
> validateNestedForms and validateComponents, but only the second one uses a
> visitor filter testing for IFormVisitorParticipant#processChildren value.
> More about: http://markmail.org/message/q2qfuyg3gcrurxxp
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
