[
https://issues.apache.org/jira/browse/WICKET-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140557#comment-13140557
]
Pedro Santos commented on WICKET-3899:
--------------------------------------
@Igor, we have no reason to be worried about ValidationVisitor being broke
because of the parodox of it being testing a variable relevant for preorder
visits while performing a post one. What happens is that
Visits#visitPostOrderHelper visit all components in the tree using preorder to
test their "visitChildren" control flag.
void visitPostOrderHelper(){
if (filter.visitChildren(container)){
visitPostOrderHelper(); <-- goes deeper only after test if visit children
is allowed, the preorder logic.
}
visitor.component(component, visit); <-- the visit code is placed only after
the recursion one, characterizing the postorder, even after the pre one being
used before to test how deep to go in the tree
}
> IFormVisitorParticipant don't get tested when validation method is visiting
> inner forms
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-3899
> URL: https://issues.apache.org/jira/browse/WICKET-3899
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.17, 1.5-RC5.1
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Attachments: WICKET-3899-fix-test.patch, WICKET-3899.patch
>
>
> The inconsistencies is at Form#validate method. It invokes
> validateNestedForms and validateComponents, but only the second one uses a
> visitor filter testing for IFormVisitorParticipant#processChildren value.
> More about: http://markmail.org/message/q2qfuyg3gcrurxxp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
