[
https://issues.apache.org/jira/browse/WICKET-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104269#comment-13104269
]
Pedro Santos commented on WICKET-4046:
--------------------------------------
Hi Emond, how this behavior of multiple instances getting touched are a bug?
Even if the touch logic gets removed from PageProvider, the accessed page from
page store will keep being touched by other means, like by AbstractPageManager.
It's important because one may want to get its reference calling
Page#getPageReference for further access, in which case the framework needs to
make sure it is already stored.
Anyway I'm 1+ to remove the duplicated touch logic from PageProvider as the
patch does and change this ticket from bug to improvement.
About make the RequestAdapter search for a touched page first, I would suggest
we continue this improvement discussion at WICKET-4050. This improvement was
already discussed in devs mail list and postponed to 1.5.x series.
> Multiple instances of same page in request and wrong one touched
> ----------------------------------------------------------------
>
> Key: WICKET-4046
> URL: https://issues.apache.org/jira/browse/WICKET-4046
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.1
> Reporter: Emond Papegaaij
> Attachments: pageprovider-notouch.diff
>
>
> The patch for WICKET-4021 can cause an unused instance of a page to be
> touched. This page is then stored by the page store, rather than the page
> used in the request. The attached patch cleans up PageProvider, by removing
> the touch call and makes the RequestAdapter search for a touched page first
> and only then load it from the page store.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
