[
https://issues.apache.org/jira/browse/WICKET-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105146#comment-13105146
]
Emond Papegaaij commented on WICKET-4046:
-----------------------------------------
The same effect can be achieved in PageProvider with this patch. Your testcases
still pass. I don't think there is any need for a second reference to an
IRequestablePage, which should always be te same page as 'pageInstance'.
I did notice one more curious thing tho: getPageParameters() only works on the
pageInstance field, not on getPageInstance. This means it will return null when
the page has not yet been fetched from the store. I guess those references
should be changed to getPageInstance().
> Touch pages only when they are returned from the data stores
> ------------------------------------------------------------
>
> Key: WICKET-4046
> URL: https://issues.apache.org/jira/browse/WICKET-4046
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.0, 1.5.1
> Reporter: Emond Papegaaij
> Assignee: Martin Grigorov
> Fix For: 1.5.1
>
> Attachments: WICKET-4046-2.diff, WICKET-4046.patch,
> pageprovider-notouch.diff
>
>
> The patch for WICKET-4021 can cause an unused instance of a page to be
> touched. This page is then stored by the page store, rather than the page
> used in the request. The attached patch cleans up PageProvider, by removing
> the touch call and makes the RequestAdapter search for a touched page first
> and only then load it from the page store.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
