[
https://issues.apache.org/jira/browse/WICKET-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pedro Santos updated WICKET-4046:
---------------------------------
Attachment: WICKET-4046.patch
Emond's optimization in RequestAdapter fixed the bug by preventing the second
deserialization. But PageProvider still needs to be improved to not try to find
a page for the same id more than one time, and always test the page class after
get it from page store.
attached patch:
- also fix the double deserialization in PageProvider
- prevents a different page with the same page id in PageProvider from affect
the isNewPageInstance state.
- test case preventing the bug
> Touch pages only when they are returned from the data stores
> ------------------------------------------------------------
>
> Key: WICKET-4046
> URL: https://issues.apache.org/jira/browse/WICKET-4046
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.0, 1.5.1
> Reporter: Emond Papegaaij
> Assignee: Martin Grigorov
> Fix For: 1.5.1
>
> Attachments: WICKET-4046.patch, pageprovider-notouch.diff
>
>
> The patch for WICKET-4021 can cause an unused instance of a page to be
> touched. This page is then stored by the page store, rather than the page
> used in the request. The attached patch cleans up PageProvider, by removing
> the touch call and makes the RequestAdapter search for a touched page first
> and only then load it from the page store.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
