martin-g commented on code in PR #1357:
URL: https://github.com/apache/wicket/pull/1357#discussion_r2722815914
##########
wicket-core/src/main/java/org/apache/wicket/core/random/DefaultSecureRandomSupplier.java:
##########
@@ -42,7 +41,7 @@ public DefaultSecureRandomSupplier()
}
catch (NoSuchAlgorithmException e)
{
- throw new WicketRuntimeException(e);
+ random = new SecureRandom();
Review Comment:
I am not sure that this is a good solution. This is the default random
supplier impl that works "most of the time".
If one needs to use a custom RandomSupplier then (s)he needs to do
`getApplication().getSecuritySettings().setRandomSupplier(...)`
https://github.com/apache/wicket/blob/a12f1ca56837e7cf986646b916cbd5b16ee1f590/wicket-core/src/main/java/org/apache/wicket/settings/SecuritySettings.java#L204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
