tim-burke-systemware commented on code in PR #1357:
URL: https://github.com/apache/wicket/pull/1357#discussion_r2722901867
##########
wicket-core/src/main/java/org/apache/wicket/core/random/DefaultSecureRandomSupplier.java:
##########
@@ -42,7 +41,7 @@ public DefaultSecureRandomSupplier()
}
catch (NoSuchAlgorithmException e)
{
- throw new WicketRuntimeException(e);
+ random = new SecureRandom();
Review Comment:
In the case of a FIPS system:
getApplication().getSecuritySettings() will throw an exception when it
tries to create the SecuritySettings object because the SecuritySettings object
initializes its randomSupplier member with a new DefaultSecureRandomSupplier
instance. Based on the original code this will throw an exception that stops
Wicket from initializing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
