tim-burke-systemware commented on code in PR #1357:
URL: https://github.com/apache/wicket/pull/1357#discussion_r2722935612


##########
wicket-core/src/main/java/org/apache/wicket/core/random/DefaultSecureRandomSupplier.java:
##########
@@ -42,7 +41,7 @@ public DefaultSecureRandomSupplier()
                }
                catch (NoSuchAlgorithmException e)
                {
-                       throw new WicketRuntimeException(e);
+                               random = new SecureRandom();

Review Comment:
   We've attempted in setting the random supplier in our application init, but 
the exception occurs before this.  Exception:
   
   `SEVERE: Exception starting filter [SwAppApplication]
   javax.servlet.ServletException: org.apache.wicket.WicketRuntimeException: 
java.security.NoSuchAlgorithmException: SHA1PRNG SecureRandom not available
           at 
org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:467)
           at 
org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:365)
           at 
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:239)
           at 
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:221)
           at 
org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFilterConfig.java:97)
           at 
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:3908)
           at 
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4527)
           at 
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
           at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1203)
           at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1193)
           at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
           at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:76)
           at 
java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:145)
           at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:749)
           at 
org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:721)
           at 
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
           at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1203)
           at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1193)
           at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
           at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:76)
           at 
java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:145)
           at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:749)
           at 
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:211)
           at 
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
           at 
org.apache.catalina.core.StandardService.startInternal(StandardService.java:412)
           at 
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
           at 
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:874)
           at 
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
           at org.apache.catalina.startup.Tomcat.start(Tomcat.java:439)
           at com.systemware.ccisvc.embedded.EmbeddedTomcat.startTomcat(Unknown 
Source)
           at com.systemware.client.base.BaseAppInitControl.initTomcat(Unknown 
Source)
           at com.systemware.client.base.BaseAppInitControlForCM.init(Unknown 
Source)
           at com.systemware.client.base.BaseApp.main(Unknown Source)
   Caused by: org.apache.wicket.WicketRuntimeException: 
java.security.NoSuchAlgorithmException: SHA1PRNG SecureRandom not available
           at 
org.apache.wicket.core.random.DefaultSecureRandomSupplier.<init>(DefaultSecureRandomSupplier.java:45)
           at 
org.apache.wicket.settings.SecuritySettings.<init>(SecuritySettings.java:69)
           at 
org.apache.wicket.Application.getSecuritySettings(Application.java:1271)
           at com.systemware.swapp.SwAppApplication.init(Unknown Source)
           at 
org.apache.wicket.Application.initApplication(Application.java:768)
           at 
org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:441)
           ... 32 more
   Caused by: java.security.NoSuchAlgorithmException: SHA1PRNG SecureRandom not 
available
           at 
java.base/sun.security.jca.GetInstance.getInstance(GetInstance.java:159)
           at 
java.base/java.security.SecureRandom.getInstance(SecureRandom.java:389)
           at 
org.apache.wicket.core.random.DefaultSecureRandomSupplier.<init>(DefaultSecureRandomSupplier.java:41)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to