vinishjail97 opened a new pull request, #572:
URL: https://github.com/apache/incubator-xtable/pull/572

   ## *Important Read*
   - *Please ensure the GitHub issue is mentioned at the beginning of the PR*
   
   ## What is the purpose of the pull request
   
   The bundled jar in xtable-hudi-support-extensions needs a different version 
of LICENSE and NOTICE file as it bundles MIT and BSD-3 license dependencies. 
Excluded hudi-common from xtable-core to avoid the following non ASF compliant 
dependencies  in the class path. Refer xtable-hudi-support-extensions tab in 
the 
[sheet](https://docs.google.com/spreadsheets/d/1XBCZBeWqF2D5d1L4H9fRQ1QLarJq4tLgIEgnGiNdoV8/edit?usp=sharing).
 
   1. org.openjdk.jol:jol-core:jar:0.16 
   2. javax.activation:javax.activation-api:jar:1.2.0
   3. javax.ws.rs:javax.ws.rs-api:jar:2.1.1
   4. org.glassfish.web:javax.servlet.jsp:jar:2.3.2
   5. org.glassfish:javax.el:jar:3.0.0
   6. javax.xml.bind:jaxb-api:jar:2.2.11
   
   
   ## Brief change log
   
   *(for example:)*
   - *Create separate LICENSE and NOTICE files for 
xtable-hudi-support-extensions*
   - *Excluded hudi-common from xtable-core to avoid non ASF compliant 
dependencies*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test 
coverage.
   
   Verified changes locally by building jar.
   
   ```
   mvn clean install -DskipTests
   # Verified the contents of LICENSE and NOTICE.
   jar xf 
./xtable-hudi-support/xtable-hudi-support-extensions/target/xtable-hudi-support-extensions_2.12-0.2.0-SNAPSHOT-bundled.jar
 META-INF/ 
   # Verified the presence of non-ASF compliant dependency in the class path. 
   jar tf 
xtable-hudi-support/xtable-hudi-support-extensions/target/xtable-hudi-support-extensions_2.12-0.2.0-SNAPSHOT-bundled.jar
 > jarOutput.txt 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to