vinishjail97 commented on PR #572: URL: https://github.com/apache/incubator-xtable/pull/572#issuecomment-2445424281
> Overall the changes look reasonable. I added a few suggestions for improvements. Apart from that I didn't verify the content of the jar file to see if the LICENSE info is complete. I will try to do that once all the other comments are addressed. Thanks for the feedback @zabetak, addressed comments. You can refer the [google sheet](https://docs.google.com/spreadsheets/d/1XBCZBeWqF2D5d1L4H9fRQ1QLarJq4tLgIEgnGiNdoV8/edit?usp=sharing) as well for checking licenses for transitive dependencies in the bundled jar in this section. ` Bundled Depdencies through maven-shade-plugin (After making hudi-common as provided) ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
