vinishjail97 commented on code in PR #572:
URL: https://github.com/apache/incubator-xtable/pull/572#discussion_r1822769931
##########
xtable-hudi-support/xtable-hudi-support-extensions/pom.xml:
##########
@@ -112,6 +112,13 @@
<artifactId>iceberg-parquet</artifactId>
</dependency>
+ <!-- hudi -->
+ <dependency>
+ <groupId>org.apache.hudi</groupId>
+ <artifactId>hudi-common</artifactId>
+ <scope>provided</scope>
Review Comment:
This jar will be used by hudi users for generating iceberg and delta
metadata, they would already have hudi-common in the class path so bundling
this again seemed redundant.
https://github.com/apache/incubator-xtable/blob/main/xtable-hudi-support/xtable-hudi-support-extensions/src/main/java/org/apache/xtable/hudi/sync/XTableSyncTool.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
