ashvina commented on code in PR #647:
URL: https://github.com/apache/incubator-xtable/pull/647#discussion_r1953902143
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionTarget.java:
##########
@@ -66,9 +66,9 @@
import org.apache.xtable.spi.sync.ConversionTarget;
public class DeltaConversionTarget implements ConversionTarget {
- private static final String MIN_READER_VERSION = String.valueOf(1);
+ private static final String MIN_READER_VERSION = String.valueOf(3);
Review Comment:
Is this change related to `timestamp_ntz`? Increasing the `min_reader`
version could break certain consumers using old libraries. If it's unrelated,
could we create a separate issue for this and perhaps make it configurable?
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaSchemaExtractor.java:
##########
@@ -61,6 +61,11 @@ public class DeltaSchemaExtractor {
private static final String DELTA_COLUMN_MAPPING_ID =
"delta.columnMapping.id";
private static final String COMMENT = "comment";
private static final DeltaSchemaExtractor INSTANCE = new
DeltaSchemaExtractor();
+ // Timestamps in Delta are microsecond precision by default
Review Comment:
Does XTable need to handle nanoseconds precision?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
