vinishjail97 commented on code in PR #647:
URL: https://github.com/apache/incubator-xtable/pull/647#discussion_r1954117802
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionTarget.java:
##########
@@ -66,9 +66,9 @@
import org.apache.xtable.spi.sync.ConversionTarget;
public class DeltaConversionTarget implements ConversionTarget {
- private static final String MIN_READER_VERSION = String.valueOf(1);
+ private static final String MIN_READER_VERSION = String.valueOf(3);
Review Comment:
Delta does the automatic version upgrade today based on the schema of the
table and other properties, if we call the same function when initializing the
delta table it shouldn't break anything.
https://docs.delta.io/2.0.0/versioning.html
`When creating a table, Delta Lake chooses the minimum required protocol
version based on table characteristics such as the schema or table properties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
