ashvina commented on code in PR #647:
URL: https://github.com/apache/incubator-xtable/pull/647#discussion_r1955314418
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionTarget.java:
##########
@@ -66,9 +66,9 @@
import org.apache.xtable.spi.sync.ConversionTarget;
public class DeltaConversionTarget implements ConversionTarget {
- private static final String MIN_READER_VERSION = String.valueOf(1);
+ private static final String MIN_READER_VERSION = String.valueOf(3);
Review Comment:
Thanks for the pointers.
However, I believe this change will force an upgrade to the `min_reader`
version, even if none of the table features require it. I support updating the
version, but lets not mix it in this PR unless it is needed for timezone
handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
