vinishjail97 commented on code in PR #882:
URL: https://github.com/apache/incubator-xtable/pull/882#discussion_r3732251164
##########
.github/workflows/mvn-ci-build.yml:
##########
@@ -43,5 +43,25 @@ jobs:
distribution: 'temurin'
cache: maven
+ # `cache: maven` above only persists ~/.m2/repository. The build cache
+ # extension configured in .mvn/extensions.xml writes to
~/.m2/build-cache,
+ # so without this it starts empty on every run and never restores a
module.
+ # Only `main` writes an entry, so pull requests warm up from `main`
instead
Review Comment:
@slachiewicz This is for my understanding as the PR description wasn't
clear, how is this cache invalidated and how are we ensuring the cached build
is only used for PR's that produce the same binaries/jars as the main branch?
I'm not aware of maven internals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
