slachiewicz commented on PR #882: URL: https://github.com/apache/incubator-xtable/pull/882#issuecomment-5246136270
Pushed four commits after a self-review pass. One of them corrects a claim I made in this PR's own description, so flagging it rather than burying it in a force-push. **`38ffe62` — the sole-writer rationale was wrong.** I wrote that License Check "must resolve every dependency to inspect each jar's license, so it populates exactly what the other jobs need". It does not. `apache-rat:check` declares no dependency resolution, `dependency:tree` collects poms rather than jars, and the shaded-bundle step names three modules and reaches only their `-am` closure — and `-am` makes dependencies, not dependents. `xtable-utilities` and `xtable-service` are leaves, so nothing in that job resolves the Quarkus stack, xtable-utilities' bundled dependencies, or `maven-install-plugin`. Since Maven CI Build is restore-only by construction, it could never have filled the gap: it would have re-downloaded that delta from Central on every run, permanently. A `dependency:go-offline` step over the full reactor, on `main` only, covers what the license steps do not. **`3414da6` — @the-other-tim-brown's failsafe question, answered [in the thread](https://github.com/apache/incubator-xtable/pull/882#discussion_r3753441277).** Short version: yes, failsafe needed it, and testing the surefire block instead of assuming it found that `-Dmaven.test.skip=true` restores a cached build whose tests never ran. Reproduced and then closed with a compiler `testCompile` reconcile. **`95dad45` — the size guard did not cover its own boundary.** Save was gated on `< 100`, the warning fired above `100`, so exactly 100 MB (reachable; `du -sm` rounds up) was skipped in silence — the one outcome the guard exists to surface. The save is also now conditional on the restore having missed, so re-running a `main` commit stops writing over its own immutable entry and logging the "Unable to reserve cache with key" these commits removed elsewhere. **`16035f4`** — `jdk11` was a literal in four cache keys across two files that have to agree on the key; now one `JDK_VERSION`. Verification, all on Temurin 11: the before/after and negative control for the reconcile are in the thread; `dependency:go-offline` exits 0 across the reactor; `spotless:check` passes; both workflows parse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
