the-other-tim-brown commented on code in PR #882:
URL: https://github.com/apache/incubator-xtable/pull/882#discussion_r3751249690


##########
.mvn/maven-build-cache-config.xml:
##########
@@ -0,0 +1,59 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+-->
+<cache xmlns="http://maven.apache.org/BUILD-CACHE-CONFIG/1.3.0";
+       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+       xsi:schemaLocation="http://maven.apache.org/BUILD-CACHE-CONFIG/1.3.0 
https://maven.apache.org/xsd/build-cache-config-1.3.0.xsd";>
+    <configuration>
+        <enabled>true</enabled>
+        <remote enabled="false"/>
+        <local>
+            <!--
+              One generation per module. The default of 3 accumulates 
generations,
+              which matters because CI persists this directory between runs; a
+              single generation keeps the saved entry at one build's size.
+            -->
+            <maxBuildsCached>1</maxBuildsCached>
+        </local>
+    </configuration>
+    <executionControl>
+        <reconcile>
+            <plugins>
+                <!--
+                  Command line flags are not part of a module's checksum, so 
without
+                  this a build that skipped tests and one that ran them are
+                  indistinguishable to the cache. Listing a property makes any
+                  difference between the cached build and the current run a 
cache
+                  miss, in both directions.
+
+                  Deliberately no skipValue attribute: skipValue is a 
relaxation, not
+                  a guard. It tells the cache to tolerate a mismatch when the 
current
+                  run is the one skipping, which is exactly the exemption we 
do not
+                  want on a release build.
+                -->
+                <plugin artifactId="maven-surefire-plugin" goal="test">

Review Comment:
   Do we need a similar config for the failsafe plugin?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to