Akash3121 commented on code in PR #938:
URL: https://github.com/apache/incubator-xtable/pull/938#discussion_r4051737375
##########
xtable-utilities/src/main/java/org/apache/xtable/utilities/RunCatalogSync.java:
##########
@@ -193,6 +196,8 @@ public static void main(String[] args) throws Exception {
conversionController.syncTableAcrossCatalogs(
conversionConfig,
getConversionSourceProviders(tableFormats, tableFormatConverters,
hadoopConf));
+ } catch (NotSupportedException e) {
Review Comment:
Nice catch, this NSE rethrow changed the existing per table failure
isolation and causes the remaining configured tables to skip. I'll remove the
rethrow and log so that the loop continues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
