Akash3121 commented on code in PR #938:
URL: https://github.com/apache/incubator-xtable/pull/938#discussion_r4052271613
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionSource.java:
##########
@@ -215,6 +223,17 @@ public CommitsBacklog<Long> getCommitsBacklog(
.build();
}
+ private void validateActiveDeletionVectors() {
+ Snapshot snapshot = deltaLog.snapshot();
+ Iterator<AddFile> activeFiles = snapshot.allFiles().toLocalIterator();
Review Comment:
Fixed. `validateActiveDeletionVectors` now checks
`snapshot.deletionVectorsSupported()` before listing active files. Tables
whose protocols do not support deletion vectors skip the Spark-backed full-file
scan, while DV-enabled tables retain the existing active-snapshot validation.
Added focused tests too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
