Akash3121 commented on code in PR #938:
URL: https://github.com/apache/incubator-xtable/pull/938#discussion_r4052274921
##########
xtable-core/src/main/java/org/apache/xtable/kernel/DeltaKernelConversionSource.java:
##########
@@ -175,12 +201,14 @@ public TableChange getTableChangeForCommit(Long
versionNumber) {
public CommitsBacklog<Long> getCommitsBacklog(
InstantsForIncrementalSync instantsForIncrementalSync) {
Table table = Table.forPath(engine, basePath);
+ Snapshot latestSnapshot = table.getLatestSnapshot(engine);
+ dataFileExtractor.validateDeletionVectors(latestSnapshot, table, engine,
deletionVectorHandler);
Review Comment:
Fixed - being consistent with DeltaConversion file
latest snapshot protocol is checked with `
TableFeatures.DELETION_VECTORS_RW_FEATURE` before invoking the full Kernel
scan-file validation. Tables without the feature skip the replay, while
feature-enabled tables retain the existing validation. Added focused tests for
both branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
