vinishjail97 commented on PR #895: URL: https://github.com/apache/incubator-xtable/pull/895#issuecomment-6091804443
Thanks for taking this on @the-other-tim-brown, and thanks for the "License Check has never run" section in the description. That the check had been exiting 0 on `rg: command not found` since #822 is the real finding here, and it explains why #857 and #885 looked at odds with each other. The overall shape looks right to me: one canonical `LICENSE`/`NOTICE` per jar, the hive-metastore whitelist regenerated for Hive 3.1.3, and two checks that fail on the gaps instead of passing silently. One thing I would like your view on before this lands, left as an inline comment: the Maven CI build fails at spotless on the new Python script because `black` is not on the runner, and the two sibling scripts are already excluded in the root `pom.xml`. Two CI housekeeping items as well, both non-blocking from my side but they keep the checks red: the three commits carry the Claude co-author trailer that `validate-commit-coauthor` rejects, and `validate-pr-title` only accepts a single `[<issue>]` prefix, so `[865][701]` falls through to the conventional-commit check. On scope, I agree the thin-jar `META-INF/licenses/` part of #701 is best left out, and the `junit`/`hamcrest-core` exclusion reads to me like a separate PR. It would be good to land this in 0.5.0 so the release vote can rely on a green License Check again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
