vinishjail97 commented on PR #895: URL: https://github.com/apache/incubator-xtable/pull/895#issuecomment-6091826747
Thanks for picking this up @the-other-tim-brown, and for negative-testing each new check. I re-ran this against latest `main` (a12f6f0b). It merges cleanly, all three validators and `apache-rat:check` pass, and regenerating the metadata gives no diff. `main`'s License Check still logs `rg: command not found`, so the fix is still needed, and it would be good to land this in 0.5.0. Three CI items before it lands: 1. Spotless fails on the new script (inline comment). 2. `validate-pr-title` rejects `[865][701]`. Would `[865] ...` work, with `Closes #701` in the body? 3. `validate-commit-coauthor` flags the trailer on all three commits. On the path question from [dev@](https://lists.apache.org/thread/tnw9o3ogn1flt2mbc0mncycshd7j43sv): general@ settled on Justin's [`releasecheck`](https://github.com/apache/incubator/tree/master/tools/skills/releasecheck) skill, whose `check_rc.py` is deterministic ([thread](https://lists.apache.org/thread/tsgfkq40s876fn0gfrzrqb2pnf6qfdb0)). Cloudberry ran it before 2.2.0-rc2 and still drew a -1 ([mail](https://lists.apache.org/thread/okjnybzo9vc9jpjstgg9vv0ckhdfmlgt)), so it narrows review rather than replacing it. I ran `check_rc.py` on `main`'s bundled jars. It does not open `.jar` files, and when they are renamed to `.zip` it treats them as source releases and looks for LICENSE at the root, not under `META-INF/`. It never compares the shade includes or `META-INF/licenses/` with the bundled dependencies. So I read the two as complementary: these checks for the shaded jars on every PR, and `releasecheck` on the source tarball before each vote. Adding that step to `release/release_guide.md` could be a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
