vinishjail97 commented on code in PR #895:
URL: https://github.com/apache/incubator-xtable/pull/895#discussion_r4393919416
##########
xtable-utilities/pom.xml:
##########
@@ -682,20 +633,13 @@
<include>org.apache.spark:spark-unsafe_${scala.binary.version}</include>
<include>org.apache.thrift:libfb303</include>
<include>org.apache.thrift:libthrift</include>
- <include>org.apache.twill:twill-api</include>
- <include>org.apache.twill:twill-common</include>
- <include>org.apache.twill:twill-core</include>
-
<include>org.apache.twill:twill-discovery-api</include>
-
<include>org.apache.twill:twill-discovery-core</include>
- <include>org.apache.twill:twill-zookeeper</include>
<include>org.apache.velocity:velocity</include>
<include>org.apache.xbean:xbean-asm9-shaded</include>
<include>org.apache.xtable:xtable-api</include>
<include>org.apache.xtable:xtable-aws</include>
<include>org.apache.xtable:xtable-core_${scala.binary.version}</include>
<include>org.apache.xtable:xtable-hive-metastore</include>
Review Comment:
Could the description mention the 64 `xtable-utilities` includes this drops?
It becomes the commit message, and it currently says only that utilities stays
unchecked. In an older local tree, every pruned entry I checked (hbase, twill,
tephra, hadoop-hdfs, hive-service, HikariCP) came in through
`xtable-hive-metastore`, so the pruning looks right to me after #979.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]