> On 29 Oct 2015, at 20:34, Andrew Wang <andrew.w...@cloudera.com> wrote: > > Has anything changed regarding the github integration since the last time > we discussed this? That blog post is from 2014, and we discussed > alternative review systems earlier in 2015. > > Colin specifically was concerned about forking the discussion between JIRA > and other places: > > http://search-hadoop.com/m/uOzYtkYxo4qazi&subj=Re+Patch+review+process > http://search-hadoop.com/m/uOzYtSz7z624qazi&subj=Re+Patch+review+process > > There are also questions about PRs leading to messy commit history with the > extra merge commits. Spark IIRC has something to linearize it again, which > seems important if we actually want to do this. > > Could someone outline the upsides of using github? I don't find the review > UI particularly great compared to Gerrit or even RB, and there's the merge > commit issue. For instance, do we think using Github would lead to more > contributions? Improved developer workflows? Have we re-examined > alternatives like Gerrit or RB as well?
I've been using it for some ATS integration work For simple patches, you can do some good review cycles https://github.com/apache/spark/pull/9232 For something big, well, it gets big https://github.com/apache/spark/pull/8744#discussion_r43388336 ... you have to switch to the many-file view, which kind of loses some of the temporal ordering of comments —instead you get lots of little threads on individual issues. Which may scale better https://github.com/apache/spark/pull/8744/files I'd need more experience to come to a real conclusion. What I do like is the immediate push-to-trigger rebuild process, no need to create patches and submit them. That I like. > On Thu, Oct 29, 2015 at 12:25 PM, Arpit Agarwal <aagar...@hortonworks.com> > wrote: > >> +1, thanks for proposing it. >> >> >> >> >> >> On 10/29/15, 10:47 AM, "Owen O'Malley" <omal...@apache.org> wrote: >> >>> All, >>> For code & patch review, many of the newer projects are using the >> Github >>> pull request integration. You can read about it here: >>> >>> >> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and >>> >>> It basically lets you: >>> * have mirroring between comments on pull requests and jira >>> * lets you close pull requests >>> * have mirroring between pull request comments and the Apache mail lists >>> >>> Thoughts? >>> .. Owen >>
