On Thu, Oct 29, 2015 at 2:29 PM, Steve Loughran <ste...@hortonworks.com> wrote:
> > > On 29 Oct 2015, at 20:34, Andrew Wang <andrew.w...@cloudera.com> wrote: > > > > Has anything changed regarding the github integration since the last time > > we discussed this? That blog post is from 2014, and we discussed > > alternative review systems earlier in 2015. > > > > Colin specifically was concerned about forking the discussion between > JIRA > > and other places: > > > > http://search-hadoop.com/m/uOzYtkYxo4qazi&subj=Re+Patch+review+process > > http://search-hadoop.com/m/uOzYtSz7z624qazi&subj=Re+Patch+review+process > > > > There are also questions about PRs leading to messy commit history with > the > > extra merge commits. Spark IIRC has something to linearize it again, > which > > seems important if we actually want to do this. > > > > Could someone outline the upsides of using github? I don't find the > review > > UI particularly great compared to Gerrit or even RB, and there's the > merge > > commit issue. For instance, do we think using Github would lead to more > > contributions? Improved developer workflows? Have we re-examined > > alternatives like Gerrit or RB as well? > > I've been using it for some ATS integration work > > For simple patches, you can do some good review cycles > > https://github.com/apache/spark/pull/9232 > > For something big, well, it gets big > > https://github.com/apache/spark/pull/8744#discussion_r43388336 > > ... you have to switch to the many-file view, which kind of loses some of > the temporal ordering of comments —instead you get lots of little threads > on individual issues. Which may scale better > > https://github.com/apache/spark/pull/8744/files > > I'd need more experience to come to a real conclusion. What I do like is > the immediate push-to-trigger rebuild process, no need to create patches > and submit them. That I like. > > I like this streamlining a lot too, but it's also something Gerrit provides. I also prefer Gerrit's review interface to Github. Gerrit also has nice interdiff support, which AFAICT Github does not support at all. You can push patch revs on top of a PR, but it doesn't show interdiffs when you force push. PRs seem designed for a merge rather than rebase workflow, which is at odds with our existing dev workflow. If I had my druthers, we'd focus on Gerrit rather than Github as a successor review system. Better review, better fits our dev workflow. The only question is JIRA integration. Best, Andrew
