On 10/29/15, 5:14 PM, "Andrew Wang" <andrew.w...@cloudera.com> wrote:
>On Thu, Oct 29, 2015 at 4:58 PM, Arpit Agarwal <aagar...@hortonworks.com> >wrote: > >> On 10/29/15, 3:48 PM, "Andrew Wang" <andrew.w...@cloudera.com> wrote: >> >> >> > If we pushed for it, I think it could happen. >> >> Gerrit support is a complete unknown. The community response to date >> supports Github integration. Github will appeal to new contributors as >> their Github profiles will reflect their work. I'd be interested in hearing >> more contributor opinions. >> >> Owen said above that he was proposing using github as a review tool, not >for code integration. So contributors wouldn't have anything showing up on >their github profiles, since we aren't directly taking PRs. > >However, if we were to use GH for integration, it would be with the >auto-squash to avoid the merge commit. Would this preserve the correct >attribution? The original mail said pull request integration. Unless infra is planning on Gerrit integration soon it's not a practical alternative. >> >> > If that's the case, we should also look at review alternatives >> > like RB and Crucible. >> >> Okay by me if the community consensus supports one of them. The fact that >> they exist but no one uses them is not a ringing endorsement. >> >> HBase uses reviewboard, as do I'm sure other Apache projects. >reviews.apache.org existed before we had github integration. I've used RB a >fair bit, and don't mind it. I could not get RB working with the Hadoop sub-projects. Would you be willing to try it out on a Hadoop/HDFS Jira since you have experience with it?
