I think we should take more than 24 hours of discussion to make a big, fundamental change to our code review process.
I used github while working on the Spark project, and frankly I didn't like it. I didn't like the way it split the discussion between JIRA and github. Also, often people would file a jira about something where the was already a patch up on github for a different jira (or sometimes no jira at all). This led to a lot of frustration where several people would post patches and only some of them would actually get looked at. github doesn't have the powerful searching or bug tracking tools of JIRA. Basically, imagine jira with no way to search for related issues, no JQL, no "assignee", no "target version", "fix version", or "component". No "in progress" versus "open". All you would have is a "list of pull requests" and perhaps a username next to each item. This system was very hard on newbies because their patches seldom got looked at. It is hard to find anything in that pile. I think the Spark guys eventually built some kind of UI on top of github to help them search through pull requests. We would probably also need something like this. Spark uses github partially because it started as a github project, so everyone was familiar with that. I haven't seen an answer to Andrew's question about what the value add is here for Hadoop to move to a new system. I have seen a few comments about a better review UI and one-click patch submission, is that the main goal? Colin On Fri, Oct 30, 2015 at 9:19 AM, Owen O'Malley <omal...@apache.org> wrote: > It seems like there is overwhelming support for enabling the github > integration, so I went ahead and filed the infra ticket > <https://issues.apache.org/jira/servicedesk/agent/INFRA/issue/INFRA-10690>. > > This is explicitly not changing the way that we commit on Hadoop and > commits should be squashed and rebased rather than merged on to the master > branch. If you want to close a pull request with a commit, just add a line > at the end of the commit message that says: > > closes apache/hadoop#123 > > If someone else wants to setup gerrit, we can evaluate it. However, I am > skeptical that it would be so much better than Github that it would be > worth making people learn a new tool. > > Thanks, > Owen
