In more detail, I'm +1 for requiring 'git format-patch' and commit with
'dev-support/bin/smart-apply-patch --committer', as well as Apache Yetus.
That way committers can use signed-off feature and don't need to add
'contributed by ...' to commit message by hand.
Thanks,
Akira
On 11/8/16 04:38, Allen Wittenauer wrote:
On Nov 7, 2016, at 11:29 AM, Ravi Prakash <ravihad...@gmail.com> wrote:
I have a preference for d) Contributed by XXX.
Wouldn't signed-off require the commit to come from the contributor? What
about people who submit patch files?
If the patches are built with 'git format-patch', no.
In Apache Yetus, we moved to requiring that patch format + committing
with 'smart-apply-patch --committer'. Makes life much easier, esp when it
comes time to see who is actually contributing patches.
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org
