Thanks Akira Ajisaka, Ravi Prakash,Andrew wang,Allen Wittenauer and Daniel..
Some are favored for option d ( i.e" contributed by XXX.") and Akira and Allen are suggesting to use "signed-off-feature" with git-format-patch. Many other communities, like Yetus,HBase,Spark all are enforcing for git-format-patch, can we also do this..? So how to conclude on this..? Seems to be we can't commit author as contributor , as Andrew pointed.(contributors will not having the apache mail-id). can we recommend contributors to keep consistent email-Id..? Would like to add one more point , "smart-apply-patch" can improve like auto commit to specified branches , which makes things easier for committer..? Regards Brahma Reddy Battula -----Original Message----- From: Akira Ajisaka [mailto:ajisa...@oss.nttdata.co.jp] Sent: 08 November 2016 10:05 To: Allen Wittenauer; Ravi Prakash Cc: Daniel Templeton; Brahma Reddy Battula; common-dev@hadoop.apache.org Subject: Re: [DISCUSS] Commit log Pattern Unification In more detail, I'm +1 for requiring 'git format-patch' and commit with 'dev-support/bin/smart-apply-patch --committer', as well as Apache Yetus. That way committers can use signed-off feature and don't need to add 'contributed by ...' to commit message by hand. Thanks, Akira On 11/8/16 04:38, Allen Wittenauer wrote: > >> On Nov 7, 2016, at 11:29 AM, Ravi Prakash <ravihad...@gmail.com> wrote: >> >> I have a preference for d) Contributed by XXX. >> >> Wouldn't signed-off require the commit to come from the contributor? >> What about people who submit patch files? > > If the patches are built with 'git format-patch', no. > > In Apache Yetus, we moved to requiring that patch format + committing > with 'smart-apply-patch --committer'. Makes life much easier, esp when it > comes time to see who is actually contributing patches. > --------------------------------------------------------------------- > To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org > For additional commands, e-mail: common-dev-h...@hadoop.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
